[devinsba]

Kyek, on 31 December 2010 - 01:05 AM, said:

Is the dump not showing all the child properties? I'm not seeing the "widget" or "module" fields you refer to in the template.

they are methods, getModule and getWidget, I kindof cheated your use of automatically trying different methods, link to full class below

https://github.com/d...ugin/Plugin.php

[Kyek]

Ah, my bad xD Lordy, you'd think I'd know my own code better than this ;-)

[Koen]

I've made a filter to parse filesizes, feed it the filesize in bytes and it'll return a string with a nicely formatted filesize.

Source:

Spoiler

<?php
namespace hydrogen\view\engines\hydrogen\filters;

use hydrogen\view\engines\hydrogen\Filter;
use hydrogen\view\engines\hydrogen\exceptions\TemplateSyntaxException;

class ParseFileSizeFilter implements Filter {

	public static function applyTo($string, $args, &$escape, $phpfile) {
		$phpfile->addFunction('parseFileSize', array('$bytes'), '{$size = $bytes / 1024; if($size < 1024) {$size = number_format($size, 2); $size .= \' KB\'; } else if($size / 1024 < 1024){$size = number_format($size / 1024, 2); $size .= \' MB\';} else if ($size / 1024 / 1024 < 1024) {$size = number_format($size / 1024 / 1024, 2); $size .= \' GB\';} return $size;}');
		$string = '(parseFileSize((int)' . $string . '))';
		$escape = false;
		
		return $string;
	}

}
?>

[Kyek]

Sweet! A few pointers:

• For Django compatibility, let's name it 'filesizeformat'. Might make someone's life easier when switching to Hydrogen from some other engine
  
• The parser will automatically convert all filters to lowercase and cap the first character when looking for the class name. So instead of FileSizeFormatFilter, you'd want FilesizeformatFilter. I know, it looks a lot less clean, but otherwise I'd have to get the directory listing of all the filters to compare case-insensitive, and that'd be way slow.
  
• Optimize! $var / 1024 / 1024 looks good, but you can cut out an operation there. It may not seem like much, but for someone with 200 file size listings, that definitely has an impact
  
• The $code argument of PHPFile->addFunction puts the { and } in for you -- no need to put that in your code . Props on learning to use that with zero documentation, though!

Cover all that, and if you send me a pull request on github, this will definitely go in under your name

[Koen]

Kyek, on 31 December 2010 - 01:53 PM, said:

Sweet! A few pointers:

• The $code argument of PHPFile->addFunction puts the { and } in for you -- no need to put that in your code . Props on learning to use that with zero documentation, though!

It does not

For the other points, will do!

Edit: New source:

Spoiler

<?php
namespace hydrogen\view\engines\hydrogen\filters;

use hydrogen\view\engines\hydrogen\Filter;
use hydrogen\view\engines\hydrogen\exceptions\TemplateSyntaxException;

class FilesizeformatFilter implements Filter {

	public static function applyTo($string, $args, &$escape, $phpfile) {
		$phpfile->addFunction('parseFileSize', array('$size'), '{
			$size = (int)$size;
			if (($size = $size / 1024) < 1024){
				$size = number_format($size, 2);
				return $size . \' KB\';
			} else if (($size = $size / 1024) < 1024) {
				$size = number_format($size, 2);
				return $size . \' MB\';
			} else if (($size = $size / 1024) < 1024) {
				$size = number_format($size, 2);
				return $size . \' GB\';
			}}');
		$string = '(parseFileSize(' . $string . '))';
		$escape = false;
		
		return $string;
	}

}
?>

[Kyek]

PWNbear, on 31 December 2010 - 01:55 PM, said:

It does not

Goddamn, it should. Checking it out ;-)

Quote

For the other points, will do!

Looks fantastic! If you've tested all the edge cases and it's working, send me a pull request on github!

[Kyek]

devinsba, on 31 December 2010 - 12:45 AM, said:

I am still getting the Undefined Offset: 1 warning in ContextStack. This seems to be called in these for loops

Ok, I *think* I got this covered. I definitely fixed a bug with for loops, I'm just not sure if that's the bug you were running into or not. If it still doesn't work after you update, let me know and I'll play around a bit more. Might have to wait until you can grab that stack trace, though

[devinsba]

Kyek, on 01 January 2011 - 11:20 AM, said:

Ok, I *think* I got this covered. I definitely fixed a bug with for loops, I'm just not sure if that's the bug you were running into or not. If it still doesn't work after you update, let me know and I'll play around a bit more. Might have to wait until you can grab that stack trace, though

That was it, awesome

[Kyek]

Kickass =D

Kyek, on 31 December 2010 - 02:27 PM, said:

Looks fantastic! If you've tested all the edge cases and it's working, send me a pull request on github!

psst, pwn-- I can take your code and commit it into the repo myself, but then it won't have your name on it. I'd like to whip up a release soon, though, so just tell me which you'd like to do

[Kyek]

Double-posting to announce 10 new filters added to the documentation

The latest update now includes: DATE, DEFAULT, FIRST, JOIN, LAST, LENGTH, LENGTH_IS, LINEBREAKS, LINEBREAKSBR, SLUGIFY. Enjoy

[Mo3]

So, Kyek, any news on the first official release?

[Koen]

Kyek, on 02 January 2011 - 12:14 AM, said:

Double-posting to announce 10 new filters added to the documentation

The latest update now includes: DATE, DEFAULT, FIRST, JOIN, LAST, LENGTH, LENGTH_IS, LINEBREAKS, LINEBREAKSBR, SLUGIFY. Enjoy

If you tell me how to do a pull request

You have a typo in the linebreaksbr filter, the code you use uses the linebreaks filter.

BTW is there a way to get these filters inside my controller? I don't want to copy that filesize function so my controller can send the nicely formatted size to the client. I'm using JSON and I don't want to use an entire view for generating the JSON-string.

[Kyek]

PWNbear, on 02 January 2011 - 04:29 AM, said:

If you tell me how to do a pull request

You would need a Github account, then you'd want to fork Hydrogen (so you have your own branch of Hydrogen on Github), commit your new file, then hit the link in Github to send a pull request for your commit .

If you haven't already set git up to use Github as a remote repo, there are all kinds of getting started guides here: http://help.github.com

Quote

You have a typo in the linebreaksbr filter, the code you use uses the linebreaks filter.

Thanks! Fixed

Quote

BTW is there a way to get these filters inside my controller? I don't want to copy that filesize function so my controller can send the nicely formatted size to the client. I'm using JSON and I don't want to use an entire view for generating the JSON-string.

Well, the thing is, the Filter classes are for generating PHP code that will apply the filter in the future -- and if you wanted to do that in the controller layer (which should actually probably be in a model, since you're transforming data), you'd need a function that applies that filter right now and doesn't generate PHP code. So if you would write that function into a model, it wouldn't be a duplication of code, because the filter and the pure function do completely different things

Mo3, on 02 January 2011 - 02:38 AM, said:

So, Kyek, any news on the first official release?

Pulling this from another thread

Kyek, on 28 December 2010 - 08:00 AM, said:

Here's the roadmap to 1.0:

• Complete templates. This one is practically done, but I need a test period of people using it to help find bugs and suggest tags that I really need to add in before it goes to a full release.
  
• Rewrite the Query library. It's just too heavy. The syntax will be pretty similar to what it is now, but the performance will be much better. There are some notes on this in my thread about the new SQLBeans. And on that note...
  
• Rewrite SQLBeans. This one will be a complete overhaul, but I don't think it's going to be too awful hard.
  
• Finish in-code documentation. Some classes have fantastic PHPDoc-style documentation in them, others don't have any. I need to write up what each function and class does so that it's easier for people to get into the code.
  
• Create the website and write the docs for using Hydrogen. I just need some guides on how to get going with Hydrogen that are split up and more easy to understand than the overview thread here ;-). I may not hold off 1.0 for this, but it would be really nice if they could coincide and I could hit the ground running as far as suggesting the library to people and pointing them toward the Getting Started guides.
  
• Create a project generator. Like the above, this may not hold off 1.0, but I'd like it to be there for 1.0 if I can. I just want a system where people can type in their project name and click a button to download a .zip file "starter" project. They'd be able to select whether they're writing an MVC app, a static site that they just want to use templates for, or maybe a different type of configuration, and they get back a zip file with their project already started so they see the best way to organize it.
  
• Release 1.0.

I'm not putting out any timelines yet since my free time is notoriously fickle, but I'd really love to get this thing out the door as soon as possible. Another thing I'd like to do before 1.0 is speed test Hydrogen against other frameworks to make damn good and certain that Hydrogen is the fastest thing out there, and also to get stats that I can make bar graphs with to brag about it on the homepage :D

[Koen]

Sent the pull request

[Kyek]

Merged into core Welcome to the contributors listing! https://github.com/T...en/contributors

(Also, fixed that thing where you had to put your own braces around function code. That's no longer required.)

[Koen]

Kyek, on 02 January 2011 - 10:25 AM, said:

Merged into core Welcome to the contributors listing! https://github.com/T...en/contributors

Awesome

[Kyek]

Added the documentation I tweaked it a bit to allow people to specify the number of decimal places they want it to go to, but the default is still 2 if they don't.

[derTechniker]

I really hope there is an option to either show it in american style like "1.2GB" or in german style "1,2GB" or in one of the others

[Koen]

derTechniker, on 02 January 2011 - 11:35 AM, said:

I really hope there is an option to either show it in american style like "1.2GB" or in german style "1,2GB" or in one of the others

I think Kyek's implementing that right now

[Kyek]

Tweaked it again to support the full featureset of the Django version It now handles "bytes" and "TB", and will remove trailing zeros (so 54.200 GB becomes 54.2 GB).

derTechniker, on 02 January 2011 - 11:35 AM, said:

I really hope there is an option to either show it in american style like "1.2GB" or in german style "1,2GB" or in one of the others

There isn't yet-- I didn't make that an argument in the filter itself because this will be part of the i18n library I'm writing The decimal point and thousands separator will match whatever locale you have in your config file. Not sure when the i18n package will be done ... but this filter will be changed to use it whenever it is