[Mo3]

You print all those variables to the command line. Either use

python bot.py >> log.txt

or remove the print statements and write them to the file instead.

//edit: disregard that. just woke up

[ianonavy]

Why do you open the file twice?

f = open('log.txt', 'a')

being called every loop is very inefficient. You should just use

t.write(data)

.

That said, your code could use quite a bit of cleaning up in terms of style. For example, you could use a better variable name such as

log_file

. I recommend the PEP 8 Style Guide to help clean up your code a bit.

This is how I would do it:

Spoiler

#!/usr/bin/env python

import datetime
import socket
import sys

# Configuration
channel = '#fish'
password = ''
nickname = 'ianonavy'
network = 'irc.esper.net'
nickserv_username = 'nickserv'
nickserv_url = 'services.esper.net'
port = 5555
max_buffer_size = 4096
log_filename = 'log.txt'

# Initialize IRC socket.
irc = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
irc.connect((network, port))
print irc.recv(max_buffer)
irc.send('NICK %s\r\n'
         'USER botty botty botty :Python IRC\r\n' % nickname)

# Initialize log.
try:
    log_file = open(log_filename, 'a')
except:
    print "There was an error opening the log file."
    sys.exit()

def print_and_write(string):
    """
    This simple function prints a string to the console and writes to the log.
    
    """
    print string
    log_file.write(string)

# Print
start_time = datetime.datetime.now()
print_and_write('Logging started at %s:\n' % start_time)

# Join the channel.
irc.send('JOIN %s\r\n' % channel)

while True:
    # Get the data.
    data = irc.recv(max_buffer)
    log_file.write(data)
    print data
    
    # Pong the pings.
    if 'PING' in data:
        irc.send('PONG %s\r\n' % data.split()[1])
    
    # Check for other keywords and handle them.
    data = data.lower()
    if 'nickserv!%s@%s' % (nickserv_username, nickserv_url) in data and \
            'this nickname is registered' in data:
        print "Registering to nickserv..."
        irc.send('PRIVMSG NICKSERV :IDENTIFY ' + password + '\r\n')
    if '*quit' in data:
        irc.send('QUIT\r\n')
        irc.close
        log_file.close()
        print "Exited the IRC"
        break

I'd like to note the following changes:

• I put all reused strings and data in one configuration area.
  
• I added lots of helpful comments.
  
• I made the whitespace more consistent. e.g.

  irc.send('JOIN %s\r\n' % channel)

  instead of

  irc.send ( 'JOIN ' + channel + '\r\n' )

  
  
• I used Python's method of string interpolation/formatting using the modulo operator.
  
• I cleaned up the logic of the code making it only open the file once and wrapped it in a try-catch block.
  
• I illustrated the use of Python's

  in

  keyword for finding strings.
  
• I wrote a function that both prints to the console and writes to the log to make the code more DRY.
  
• I added a shebang to the start of the script to make it more UNIX-based OS friendly.

I hope that I have helped you with your issue.

[Midareru]

well, i changed it to this.

i don't have much time to work on this due to college -.-;

Spoiler

import socket
import datetime
import ConfigParser
import re
import os

os.system('cls')

privlege_lock = False
privlege_mode = 'DISABLED'
relay_chat = False
relay_chat_mode = 'OFF'

class UnknownValue(Exception): pass
#-------------------------------------------------------------------#
#Replaces a line in setup.ini
def replace_line(old_line, new_line):
    f = open("setup.ini")
    for line in f:
        line = os.linesep.join([s for s in line.splitlines() if s]) #Gets rid of extra, blank lines
        if line == old_line:
            f1 = open("setup.ini",'r')
            stuff = f1.read()
            f1.close()
            new_stuff = re.sub(old_line,new_line,stuff)
            f = open("setup.ini",'w')
            f.write(new_stuff)
            f.close()      
#Config parser:   
def get_options(filename):
    """
    Gets the options from a config file.

    Returns a dictionary in a dictionary.
    """
    config = ConfigParser.ConfigParser()
    try:
        config.read(filename)
    except ConfigParser.ParsingError, e:
        pass
    sections = config.sections()
    output = {}
    for section in sections:
        output[section] = {}
        for opt in config.options(section):
            value = config.get(section, opt)
            output[section][opt] = value
    return output
o = get_options("setup.ini")

irc_network = o['server']['network'] #irc server adress
irc_port = o['server']['port'] #connection port
if irc_port == '5555':
	irc_port = 5555
irc_nick = o['user']['nickname'] #bot nickname
irc_indent = o['user']['indent'] #bot indent
irc_password = o['password']['nickservpass'] #bot's nickserv password
irc_real_name = o['user']['real_name'] #real name
log = o['logging']['log'] #if the program will log or not
log_path = o['logpath']['path'] #path for log files
log = log.lower()
if log == 'true':
	log = True
elif log == 'false':
	log = False
else:
	log = True
irc_ping = o['ping_setup']['ping']# if ping is on
irc_ping_colour = o['ping_setup']['ping_colour'] # the ping colour
irc_chan1 = o['channels']['c1'] #1st channel
irc_chan2 = o['channels']['c2'] #second channel
irc_chan3 = o['channels']['c3'] #third channel
relay_from = o['channels']['relay_from'] #channel for bot to relay from
relay_to = o['channels']['relay'] #channel the bot relays to
irc_theme = o['theme']['theme_use'] #if use colour themes
irc_theme_back = o['theme']['background'] #background colour
irc_theme_text = o['theme']['text'] #text colour
privlege = o['privlege']['privleges'] #if command lock is on
op1 = o['privlege_ip']['owner'] #owner 1
op2 = o['privlege_ip']['co_owner'] #owner 2
op1 = op1.lower()
op2 = op2.lower()
privlege = privlege.lower()
if privlege == 'true':
	privlege = True
	privlege_mode = 'OFF'
else:
	privlege = False
irc_theme = irc_theme.lower()
if irc_theme == 'true':
	irc_theme = True
else:
	irc_theme = False


if log == True:
	now = datetime.datetime.now()
	t = open(log_path + 'log.txt', 'a')
	t.write("\n\n\n")
	t.write("****************************************************\n")
	t.write('***logging started at :')
	t.write(str(now))
	t.write("***\n")
	t.write("****************************************************\n\n\n\n")
	t.close()
	print "logging started on: ",
	print (str(now))

def register():
	irc.send('PRIVMSG NICKSERV :IDENTIFY ' + irc_password + '\r\n')
def join_channels():
	irc.send ( 'JOIN ' + irc_chan1 + '\r\n' )
	irc.send ( 'JOIN ' + irc_chan2 + '\r\n' )
	irc.send ( 'JOIN ' + irc_chan3 + '\r\n' )

irc = socket.socket ( socket.AF_INET, socket.SOCK_STREAM )
irc.connect ( ( irc_network, irc_port ) )
print irc.recv ( 4096 )
irc.send ( 'NICK ' + irc_nick + ' \r\n' )
irc.send ( 'USER '+ irc_indent + ' ' + irc_indent + ' ' + irc_indent + ' :'+ irc_real_name +'\r\n' )

while True:
	data = irc.recv ( 4096 )
	if log == True:
		f = open(log_path + 'log.txt', 'a')
		f.write(data)
		f.close()
	if data.find ( 'PING' ) != -1:
		irc.send ( 'PONG ' + data.split() [ 1 ] + '\r\n' )
		data = ''
	print_data = data
	data = data.lower()
	if data.find ('nickserv!nickserv@services.esper.net' and 'this nickname is registered') != -1:
		register()
		join_channels()
	if data.find ('*quit') != -1:
		if data.find ('op1') != -1:
			irc.send('QUIT\r\n')
			irc.close
			break
	if data.find ('*quit') != -1:
		if data.find('op2') != -1:
			irc.send('QUIT\r\n')
			break
	if data.find(irc_nick) != -1:
		if ping == True:
			new_data = print_data
			data = ''
			os.system('color' + irc_theme_back + irc_ping_colour)
			print (new_data)
			os.system('color ' + irc_theme_back + irc_theme_text)
	if data.find ('*satus') != -1:
		irc.send('PRIVMSG ' + relay_to + ' :Lock mode is ' + privlege_mode + '\r\n')
		if privlege_lock == False:
			irc.send('PRIVMSG ' + relay_to + ' :Relay is ' + relay_chat_mode + '\r\n')
			irc.send('PRIVMSG ' + relay_to + ' :Relaying from: ' + relay_from + '\r\n')
			irc.send('PRIVMSG ' + relay_to + ' :Relaying to: ' + relay_to + '\r\n')
		
	if data.find ('*relay off') != -1:
		if privlege_lock == False:
			relay_chat = False
			relay_chat_mode = 'OFF'
			irc.send('PRIVMSG ' + relay_to + ' :Relay OFF\r\n')
		elif data.find(op1 or op2) != -1:
			relay_chat = False
			relay_chat_mode = 'OFF'
			irc.send('PRIVMSG ' + relay_to + ' :Relay OFF\r\n')
		else:
			irc.send('PRIVMSG ' + relay_to + ' :You do not have the premmesion to use that command!\r\n')
	if data.find ('*relay on') != -1:
		if privlege_lock == False:
			relay_chat = True
			relay_chat_mode = 'ON'
			irc.send('PRIVMSG ' + relay_to + ' :Relay ON\r\n')
		elif data.find (op1 or op2) != -1:
			relay_chat = True
			relay_chat_mode = 'ON'
			irc.send('PRIVMSG ' + relay_to + ' :Relay ON\r\n')
		else:
			irc.send('PRIVMSG ' + relay_to + ' :You do not have the premmesion to use that command!\r\n')
	if relay_chat == True:
		if data.find (relay_from) != -1:
			irc.send('PRIVMSG ' + relay_to + ' :' + print_data + '\r\n')
	if privlege == True:
		if data.find('*lock') != -1:
			if privlege_lock == True:
				irc.send('PRIVMSG ' + relay_to + ' :Allready in locked mode!\r\n')
			else:
				privlege_mode = 'ON'
				privlege_lock = True
				irc.send('PRIVMSG ' + relay_to + ' :Locked mode is now ON, only owners may unlock|acess now.\r\n')
	if privlege == True:
		if data.find('*unlock') != -1:
			if privlege_lock == True:
				if data.find(op1 or op2) != -1:
					privlege_lock = False
					privlege_mode = 'OFF'
					irc.send('PRIVMSG ' +relay_to + ' :Locked mode is now OFF\r\n')
				else:
					irc.send('PRIVMSG ' + relay_to + ' :You do not have the premmesion to use that command!\r\n')
			else:
				irc.send ('PRIVMSG ' + relay_to + ' :Not in locked mode!\r\n')
	print print_data
irc.close()

setup.ini

Spoiler

[server]
network = irc.esper.net
port = 5555

[nickserv]
use = True

[user]
nickname = Fish
indent = fishy
real_name = Python IRC

[ping_setup]
ping = False
ping_colour = c

[logging]
log = True

[password]
nickservpass = -snip-

[channels]
c1 = #fish
c2 = #fish|help
c3 = #
relay_from = #
relay = #

[theme]
theme_use = True
background = 0
text = 7

[privlege]
privleges = True

[privlege_ip]
owner = -snip-
co_owner = -sip-

[logpath]
path = I:/irc/1/logs/

what i really need to do is split the variable "data" into a few strings.

print (data)

returns

:Midareru!~androirc@119.224.2.55 PRIVMSG #OT :Hello World

what i'm trrying to do is make 6 new variables from "data".
the users nickname "Midareru", their indent "androirc", ip, "@119.224.2.55", message type "PRIVMSG", channel #OT, and finally the message "Hello World".

i have been sugested to use regular expressions to extract the data types, but i don't quite get it, and as i said before, i don't have the time at the moment...

i was sugested to try something like this:

nick = data.substr(1, data.find '!~' -1)

once i get that sortet, i can get this hunk of code sorted out nicely.

just a few notes:
i open the file, append to it, then close it.
this saves me the hassle of telling to bot to exit on the irc, looking at the log, then starting it up again when i just could open up the file without making the python script stop before it closes the file so i can see the text.

i use that form of whitspace as i's easyer to read for me.

[callumacrae]

Try this regex:

^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$

Note that the ident in the sample you gave isn't

androirc

, it is

~androirc

, meaning that you don't have an ident server installed.

[Midareru]

ah, i see now.

so i would use it like so?

new = data.find(^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$)

sorry if i'm getting this wrong, my brain has been fuzzy all day..

[Fike]

Midareru, on 11 May 2012 - 03:25 AM, said:

ah, i see now.

so i would use it like so?

new = data.find(^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$)

sorry if i'm getting this wrong, my brain has been fuzzy all day..

Something like

import re
new = re.match("^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$", data)

[Midareru]

using this:

import re
data = ':Midareru!~androirc@119.224.2.55 PRIVMSG #OT :Hello World'
new = re.match("^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$", data)
print (new)
pause = raw_input('press enter to exit')

i got his in return:

<_sre.SRE_Match object at 0x00DEC920>
press enter to exit

any idear what's going wrong/right?

[NeilHanlon]

New is an object, and that's what it's telling you. I'm not familiar with python, but I know in PHP, if I did print() on an array or object, it would do the same thing.

Is there a python function equivalent to print_r() or var_dump()?

[Fike]

NeilHanlon, on 12 May 2012 - 07:35 AM, said:

New is an object, and that's what it's telling you. I'm not familiar with python, but I know in PHP, if I did print() on an array or object, it would do the same thing.

Is there a python function equivalent to print_r() or var_dump()?

pprint?

[Sephern]

re.match returns a MatchObject. They always have a boolean value of true so the idea is that you call in an if, and if there's a match then it carries on (for example, if you're validating email). If you actually want to get the part of the string that is matched you can do

print(new.group(0))

.

Quote

group([group1, ...])
Returns one or more subgroups of the match. If there is a single argument, the result is a single string; if there are multiple arguments, the result is a tuple with one item per argument. Without arguments, group1 defaults to zero (the whole match is returned). If a groupN argument is zero, the corresponding return value is the entire matching string; if it is in the inclusive range [1..99], it is the string matching the corresponding parenthesized group. If a group number is negative or larger than the number of groups defined in the pattern, an IndexError exception is raised. If a group is contained in a part of the pattern that did not match, the corresponding result is None. If a group is contained in a part of the pattern that matched multiple times, the last match is returned.

>>> m = re.match(r"(\w+) (\w+)", "Isaac Newton, physicist")
>>> m.group(0)       # The entire match
'Isaac Newton'
>>> m.group(1)       # The first parenthesized subgroup.
'Isaac'
>>> m.group(2)       # The second parenthesized subgroup.
'Newton'
>>> m.group(1, 2)    # Multiple arguments give us a tuple.
('Isaac', 'Newton')

[Fike]

Midareru, on 12 May 2012 - 12:05 AM, said:

using this:

import re
data = ':Midareru!~androirc@119.224.2.55 PRIVMSG #OT :Hello World'
new = re.match("^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$", data)
print (new)
pause = raw_input('press enter to exit')

i got his in return:

<_sre.SRE_Match object at 0x00DEC920>
press enter to exit

any idear what's going wrong/right?

Here's an example I just made to demonstrate how re.match works.

import re

# Compile the regex incase you need to use it further (saves resources)
regex = re.compile("^:([^!]+)!(~?[^!@]+)@([^ @]+) (PRIVMSG) ([^ ]+) :(.+)$")

# This function takes the string and uses re.match() to check if its valid.
def privmsg_validate(string):
    valid = regex.match(string)
    if valid == None:
        return False
    else:
        return True

# Lets do some tests.
valid_line = privmsg_validate(":Midareru!~androirc@119.224.2.55 PRIVMSG #OT :Hello World")
invalid_line = privmsg_validate(":Midareru!~androirc@119.224.2.55 NOTICE #OT :Hello World")

print("Checking %s..." % valid_line)

if valid_line == True:
    print("Its valid!")
else:
    print("Doesn't appear valid.")

print("Checking %s..." % invalid_line)

if invalid_line == True:
    print("Its valid!")
else:
    print("Doesn't appear valid.")

[Midareru]

ianonavy, on 30 April 2012 - 09:24 PM, said:

Why do you open the file twice?

f = open('log.txt', 'a')

being called every loop is very inefficient. You should just use

t.write(data)

.

Yes, but if i don't keep setting that varable, it trys to write to a closed file, and will crash with an error.

instead of closing f i could just write to the file, then close the file ehen the bot is told to quit on the IRC, then i don't have any problems with writing to a closed file, and the program is more efficent.

Why i have done it the way i have is so the program logs in "real time", so that when someone says something in the channel the bot is in, it appears in CMD and in my log file (after reloading it), instead if i wanted to look at what the bot has loged, i have to shut down the bot via the IRC, and then restat it manually. also, if the bot gets an error and crashes, the program won't close the file, and the loged data will be lost.

Unless there is another way to do what i'm currently doing with the logging, this is the only way i want and can thing of logging for my bot.

ianonavy, on 30 April 2012 - 09:24 PM, said:

I'd like to note the following changes:

• I put all reused strings and data in one configuration area.
  
• I added lots of helpful comments.
  
• I made the whitespace more consistent. e.g.

  irc.send('JOIN %s\r\n' % channel)

  instead of

  irc.send ( 'JOIN ' + channel + '\r\n' )

  
  
• I used Python's method of string interpolation/formatting using the modulo operator.
  
• I cleaned up the logic of the code making it only open the file once and wrapped it in a try-catch block.
  
• I illustrated the use of Python's

  in

  keyword for finding strings.
  
• I wrote a function that both prints to the console and writes to the log to make the code more DRY.
  
• I added a shebang to the start of the script to make it more UNIX-based OS friendly.

The reason i use an external .ini file for this bot, is so that i can compile and run this bot on other machines without python installed (my hosting computer can't install it for some reason, and it runs faster compiled too), and not have permanant setting once the bot is compiled, so if i want to change the server to frenode, i can just edit my .ini file instead of chaning the py on a difrent computer, compiling, and then transefering the compiled bot to the soting computer.

---

another thing i have noticed since i have been programming this on my hosting laptop (it runs Lucid Puppy 5.2) and i have getting this once every 1-10 runs

socket.gaierror: [Errno -3] Temporary failure in name resolution

Does anyone know what this is about?